feat: added merge groups #3896
feat: added merge groups #3896
Conversation
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-added-merge-groups |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub merge group support to CI/CD workflows to enable merge queue functionality. The changes configure workflows to trigger on merge group events in addition to existing pull request triggers, supporting GitHub's merge queue feature for better branch protection.
- Adds
merge_grouptriggers to three GitHub Actions workflow files - Configures merge group events to target the "main" branch consistently
- Enables CI checks to run on merge groups as documented in GitHub's merge queue guidance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/pull-request.yml |
Added merge group trigger for main branch |
.github/workflows/pull-request-opened.yml |
Added merge group trigger for main branch |
.github/workflows/default.yml |
Added merge group trigger without branch specification |
| @@ -3,6 +3,7 @@ name: Default Pipeline | |||
|
|
|||
| on: | |||
| pull_request: | |||
| merge_group: | |||
There was a problem hiding this comment.
The merge_group trigger should specify branches for consistency with the other workflow files. Consider adding 'branches: ["main"]' to match the pattern used in pull-request.yml and pull-request-opened.yml.
| merge_group: | |
| merge_group: | |
| branches: | |
| - "main" |
Copilot uses AI. Check for mistakes.
Proposed changes
according to https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions
and
setting upactivating a new ruleset for merge groups, as documented: https://github.com/db-ux-design-system/core-web/settings/rules/3944111We should additionally have a look at https://github.com/googleapis/release-please as well.
Types of changes
Further comments